Issue 44 #46
Merged
Issue 44 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress binding fails
# Conflicts: # Sources/Shout/SSH.swift
levidhuyvetter
approved these changes
Jun 6, 2020
There was a problem hiding this comment.
I can confirm this does solve the memory leak issue.
Before:
After:
It doesn't solve my specific issue of the function not returning but that may very well be a problem with the mysql.server or mysqld_safe script. Although terminal seems to be handling it just fine.
|
Thanks for opening these PRs! Just to clarify, does this PR supercede #45? |
|
Got it. This looks good, so I'll go ahead and merge this and close #45. Thanks to both of you for looking into this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.