Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/repeating task execute #370

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

elonmitchell
Copy link
Contributor

@elonmitchell elonmitchell commented Feb 17, 2020

  • Fix the task reenabling issue using a reenabled flag variable.
  • Add a test for the repeated task execute function.
  • Fix a typo. from _skippped to _skipped.
  • Fix a lint so now the build icon is green.

Copy link
Contributor

@mde mde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is amazing, thank you.

@mde mde merged commit ccc9a82 into jakejs:master Feb 17, 2020
@mde
Copy link
Contributor

mde commented Feb 17, 2020

Awesome work, thank you for this. I've sent you an invitation to the org, to make it easier for you to contribute, if you have the inclination and time. :)

@elonmitchell
Copy link
Contributor Author

@mde please can you update the npm repository with the latest updates? thanks in advance.

@mde
Copy link
Contributor

mde commented Feb 25, 2020

Just published to NPM, v10.4.6. Apologies for the delay, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants