Fixed Cannot read property 'forEach' of undefined #6

shalkam · 2017-04-24T21:29:59Z

Fixed this error : -
TypeError: Cannot read property 'forEach' of undefined
I don't know what's causing it but adding this if statement fixed the issue

Fixed this error : - `TypeError: Cannot read property 'forEach' of undefined` I don't know what's causing it but adding this if statement fixed the issue

coveralls · 2017-04-24T21:31:15Z

Coverage remained the same at 100.0% when pulling f9fad6a on shalkam:master into 9fa1c47 on jakepusateri:master.

jakepusateri · 2017-04-25T04:33:36Z

Hi, thanks for the PR. I'd love a test case so I can figure out what caused this as well as prevent regressing it in the future. Would you be able to make a minimal repro for this?

shalkam · 2017-04-25T10:05:50Z

No, problem but until I do so the problem occurred with apollo server side rendering only
I am using a custom network interface for this purpose:

import { createLocalInterface } from 'apollo-local-query';

app.get('*', function(req, res) {
    const context = {};
    const initialState = { user: req.user };
    const client = new ApolloClient({
      ssrMode: true,
      networkInterface: createLocalInterface(graphql, schema, {
        context: { req, acl }
      })
    });
    const component = (
      <ApolloProvider client={client}>
        <StaticRouter location={req.url} context={context}>
          <App {...initialState} isServer={true} />
        </StaticRouter>
      </ApolloProvider>
    );
    getDataFromTree(component)
      .then(() => {
        initialState[client.reduxRootKey] = client.getInitialState();
        const body = renderToString(component);
        const helmet = Helmet.renderStatic();
        if (context.url) {
          res.writeHead(302, {
            Location: context.url
          });
          res.end();
        } else {
          res.send(
            `
            <!DOCTYPE html>
            <html ${helmet.htmlAttributes.toString()}>
              <head>
                <meta charset="UTF-8">
                <script>window.__APP_INITIAL_STATE__ = ${JSON.stringify(initialState)}</script>
                ${helmet.title.toString()}
                ${helmet.meta.toString()}
                ${helmet.link.toString()}
                <link rel="stylesheet" href="/assets/styles.css" />
              </head>

              <body ${helmet.bodyAttributes.toString()}>
                <div id="app">${body}</div>
                <script src="/assets/bundle.js" ></script>
              </body>
            </html>
          `
          );
        }
      })
      .catch(err => {
        console.error(err);
      });
  });

jakepusateri · 2017-10-14T00:21:27Z

Closing due to inactivity. If this still happens or you have a test case that causes the error, comment and I can reopen.

Fixed Cannot read property 'forEach' of undefined

f9fad6a

Fixed this error : - `TypeError: Cannot read property 'forEach' of undefined` I don't know what's causing it but adding this if statement fixed the issue

jakepusateri closed this Oct 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Cannot read property 'forEach' of undefined #6

Fixed Cannot read property 'forEach' of undefined #6

shalkam commented Apr 24, 2017

coveralls commented Apr 24, 2017 •

edited

Loading

jakepusateri commented Apr 25, 2017

shalkam commented Apr 25, 2017

jakepusateri commented Oct 14, 2017

Fixed Cannot read property 'forEach' of undefined #6

Fixed Cannot read property 'forEach' of undefined #6

Conversation

shalkam commented Apr 24, 2017

coveralls commented Apr 24, 2017 • edited Loading

jakepusateri commented Apr 25, 2017

shalkam commented Apr 25, 2017

jakepusateri commented Oct 14, 2017

coveralls commented Apr 24, 2017 •

edited

Loading