Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger float don't work #37

Closed
jin-park opened this issue Jan 27, 2021 · 9 comments
Closed

Bigger float don't work #37

jin-park opened this issue Jan 27, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@jin-park
Copy link

Hi :) The decimal version of spelled_out doesn't seem to work for floats bigger than 1,000,000. Maybe it's because of that "1e6" notation?

Screen Shot 2021-01-27 at 5 36 39 PM

@jakewilliami
Copy link
Owner

Hi there! I tried fixing that in #32. Can you verify that you are using the most recent version of SpelledOut? :)

@jin-park
Copy link
Author

Ah, so for some reason I cannot update the package. When I do add SpelledOut#master this error message pops up. Do you know how to fix this? :)

Screen Shot 2021-01-27 at 5 46 47 PM

@jakewilliami
Copy link
Owner

That said, what I recall of that fix felt a bit hacky. If you can think of another way to go about this, I'd be happy for you to contribute!

Strange about that error message. I've had some trouble in the past with the registry in general. Could you try add SpelledOut@1.1.0?

@jin-park
Copy link
Author

hmmm no luck :( Maybe it's a problem on my end? I guess I'll have to google this

Screen Shot 2021-01-27 at 5 51 23 PM

@jakewilliami
Copy link
Owner

Hmm, that's very strange. Please google that issue. It might be worth deleting the general registry and updating. Either way, I believe this is still an issue needing fixed, so I will work on fixing this issue now (I will reopen #32)

@jin-park
Copy link
Author

Ah I see, I'll have to try that. Well, thanks for the help :)

@jakewilliami
Copy link
Owner

Let me know how you get on :) I'll update you here when I fix this issue. Thank you for bringing this to my attention, as I now realise this must be a slightly different issue to #32 (though a similar error)

jakewilliami added a commit that referenced this issue Jan 27, 2021
Fix was to parse floats as strings ASAP.  Similar to fix for #32.  Addresses #37.
@jakewilliami jakewilliami mentioned this issue Jan 27, 2021
@jakewilliami
Copy link
Owner

@jin-park It should be fixed now. Let me know if you are happy for me to close the issue. (See also #42)

@jakewilliami jakewilliami added the bug Something isn't working label Jan 27, 2021
@jakewilliami
Copy link
Owner

I am going to close this now because I'd like to push a new version (1.1.1). We can always reopen this if you are still having problems :)

jakewilliami added a commit that referenced this issue Mar 29, 2023
Fix was to parse floats as strings ASAP.  Similar to fix for #32.  Addresses #37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants