refactor(store): Centralize store #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakipatryk
commented
Aug 10, 2018
| ); | ||
| } | ||
|
|
||
| broadcast(post: SteeditorPost): void { | ||
| this.store.dispatch(fromFeatureStore.broadcast(post)); | ||
| broadcast(draft: Draft): void { |
There was a problem hiding this comment.
It receives SteeditorPost. broadcastDraft action creator expects Draft, thus id should be added (like in updateDraft).
jakipatryk
commented
Aug 10, 2018
| @@ -7,7 +7,7 @@ | |||
| </span> | |||
|
|
|||
| <span fxFlex class="toolbar__button"> | |||
| <app-log-in-out [isAuthenticated]="isAuthenticated$ | async" [isLoggingOut]="isLoggingOut$ | async" (login)="login()" (logout)="logout()"></app-log-in-out> | |||
| <app-log-in-out [isAuthenticated]="currentUser$ | async" [isLoggingOut]="isLoggingOut$ | async" (login)="login()" (logout)="logout()"></app-log-in-out> | |||
There was a problem hiding this comment.
It probably should be cast to boolean or isAuthenticated should be renamed.
- move feature stores to one central place - base store on root and feature store NgModules - refactor file structure of every store - create SharedModule with reusable confirm dialog (component) - move store-specific components to store NgModules - update containers so they correctly use refactored store - use @ngrx/entity in drafts store
jakipatryk
force-pushed
the
refactor/central-store
branch
from
40dcc1c
to
dd17059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made mostly to avoid future problems with lazy loaded feature modules with store: