Use tobytes
in hex
to make data C contiguous
#12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only copy the data in
hex
usingtobytes
if it is not C contiguous. That way if the data is already C contiguous, a view onto the original data can be used instead saving time and memory. The copy is needed for non-C contiguous data to get a consistent representation in hex asmemoryview
and other objects do. As Python 2'sbinascii.hexlify
supports the (new) buffer protocol, it won't introduce any additional copies as long as something implementing the (new) buffer protocol is provided. On Python 3, we leveragememoryview
'shex
method, which also avoids copying if the data is C contiguous. It provides a fast path tohex
, which is equivalent to thebytes
methodhex
. Thus in both cases, the hex conversion will avoid any additional copies of the data. So this should in the best case avoid a copy when constructing the hex result, but may still copy the data if it is not contiguous in the way we expect, which is better than before.