Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/idf_component | Make this repo a IDF component + other inclusions #3

Merged
merged 7 commits into from
Jun 4, 2023

Conversation

hiruna
Copy link
Contributor

@hiruna hiruna commented Jun 1, 2023

Context

This repo was very helpful to calibrate my resisitive touch display that I'm using, however it could be improved by converting this repo into a ESP-IDF component such that projects can import this as an IDF component (via component manager or as a git submodule). This PR includes the neccessary files required to do this.

Additional changes

Kconfig

I have also included a Kconfig file to allow for configuration via the ESP Project Configuration (i.e. menuconfig).
image

UI Text Overrides

image

Timeouts

image

Custom Calibration Points

image
image

NVS Configuration

image

Calibration Coefficients

image
image
image

Log output of the calibrated coefficients

image

Reference to my testing I've been doing in the past few days: lvgl/lvgl_esp32_drivers#222

Usage of this repo/my fork: https://github.com/hiruna/lv_port_esp32/tree/develop/lvgl_8.3.7_idf_5.2

@jakpaul
Copy link
Owner

jakpaul commented Jun 4, 2023

Thanks for your contribution! This is a valid improvement, so I am merging. Just going to make sure to keep compatibility with other build systems by adding some macros in lv_tc.c.

@jakpaul jakpaul merged commit d99ac7b into jakpaul:master Jun 4, 2023
@jakpaul
Copy link
Owner

jakpaul commented Jun 4, 2023

Done: c5734d3

@hiruna
Copy link
Contributor Author

hiruna commented Jun 4, 2023

thanks for the review! i'll close this off

@hiruna hiruna deleted the feature/idf_component branch June 4, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants