Added a disabled option to DrawingMode #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @uriberto! thanks for creating both the issue and the PR, really appreciate it. I think this is a great addition to Atrament. I'm unfortunately quite busy these days, but I'll try to review the PR and test everything + update the docs and release a new minor version in the next week or two. Hope that's ok! |
|
No prob. I'm glad you agree this would be a nice addition. There's no hurry from my perspective. I don't have any immediate need for this. I just thought it would be a nice option to have. Thanks. |
jakubfiala
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just lets the instance set mode to 'disabled'. In that case, no draw/fill/erase should be triggered on mouse move. I wasn't sure if this use case should allow strokes to be created/recorded under disabled mode, so I didn't touch that.