Prevent unexpected results with dates lower than 1970 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i have tried to use rrule on this kind of event:
This does not work because
DTSTARTis lower thandateutil.ORDINAL_BASEWith this pull request, i have added an exception on the
toOrdinalmethod for dates lower than 1970-1-1this is usefull because without that the
toOrdinalmethod does not fail and give a very large number, then the fromOrdinal method give back a date greater than 2070 or something similar and thebewteenmethod give no results.Note: changing the
dateutil.ORDINAL_BASEto a lower date was fixing my problem but i can also change my icalendar source to start from 1970 instead of 1900.