Added 'key' param #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 15th September 2015, the Nominatim Service provided by MapQuest requires an AppKey. See http://open.mapquestapi.com/nominatim/ for more information. Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com>
|
Is this project going to be maintained at all? I’m going to merge this to my fork, guess I’ll merge other pull requests here to there too... |
|
Please do so. I also use a fork of your repo currently in production: |
|
Did. They’re all in master branch so consequently it should show up in my PR... I wonder if I should just publish a gem like ruby-nominatim and call it fork of this project in order to get this mess sorted out. |
|
Sounds good. 👍 |
|
Done: https://github.com/Smarre/ruby-nominatim I’ll add some migration/maintenance commits and look for the release then. I unforked the repository (i.e. deleted and recreated it) so it does not have dependency to this project any more. |
|
Awesome, will change the repo in my Gemfiles asap 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 15th September 2015, the Nominatim Service
provided by MapQuest requires an AppKey.
See http://open.mapquestapi.com/nominatim/ for more
information.
Signed-off-by: Maximilian Güntner maximilian.guentner@gmail.com