Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate() doesn't print output tokens as model generates them #3

Closed
jalammar opened this issue Dec 1, 2020 · 1 comment
Closed

generate() doesn't print output tokens as model generates them #3

jalammar opened this issue Dec 1, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jalammar
Copy link
Owner

jalammar commented Dec 1, 2020

Tested on colab with GPU. Expected behaviour is that output tokens are displayed as soon as they're generated. That does not happen with GPUs on Colab.
@jalammar jalammar added the bug Something isn't working label Dec 1, 2020
@jalammar
Copy link
Owner Author

Fixed by adding "require" blocks around 'addToken' calls. This happened because they were called before the "display" method which sets up the visualization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jalammar