Update hash table with Pokken hashes #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the bone hash table with all available hashes from Pokken. Fixes broken animation exports from that game.
|
I'll try and review and merge this later today. Thanks for looking into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the hashTable.csv file, which contains hashes for bone names. I've added all available hashes from Pokken's files. This allows animation exporting to work correctly for Pokken files, as Forge's animation export unnecessarily requires a hash mapping to be present in order to export a given bone.
All of the newly added Pokken hashes came directly from Pokken's VBN files, which were kindly provided by @wood5578, in addition to all of the testing that enabled us to arrive at this solution.
It has been four long years since I last worked on Forge. I wonder if someone is still around to merge this PR...