-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed In Unity5.3+ #6
Comments
I'm still maintaining this when time permits. Some colleagues are running on Unity 5+ and I'll look into this for you... |
It's very kind of you.Thanks for your help. |
I've had a first look at this in Unity 5.3.6 and it looks like the rendering pipeline has changed somewhat, which may be the cause. It will take some more investigation, but I'll let you know if/when I make progress. In the mean-time, if you could attach some verbose log files, that might help confirm the issue. The logging can be set to verbose as follows:
|
Sorry for my late reply. This is the log that I ran in 5.3.4f1. |
Thanks for the log file and suggestion above. I've been away for a few days, but hope to find time to look at this again soon and have some ideas. I'll write back here when I make progress. |
I've now got this working in 5.3.6f1 at this revision: 95b9b51 |
Hi Jam, |
I got this working. "Show Unity Splash Screen" must be enabled. |
Thanks for the update, much appreciated. I'm pleased to hear you got it working. It shouldn't really be necessary to have the splash enabled, so I'll look into that issue. Anyway, I'm glad you have a workaround in the mean-time. |
Hi James, |
Thanks for the suggestions, it's great to have some feedback. Regarding (1) I agree this seems sensible (and I had actually tried this at one stage myself). Logically, it seems it should actually be required, but it seems to work without for me (strangely). Strictly, I suppose we should clear all buffers (as the right eye render may not fully overdraw the left eye). There is a performance cost to clearing of course, so in the long term an option on the clear flags may be better (e.g. configuration file). For the moment, I'll do as you suggest and commit this. Regarding (2) does this fix a problem? Would be interested to understand the detail behind that (my first assumption is that Unity would set the usage) - is it needed because we have changed from D3DPOOL_MANAGED to D3DPOOL_DEFAULT and some interaction between pool and usage? Please keep the feedback coming as it is appreciated. If there are separate issues, please feel free to create separate tickets for each issue. |
The suggested CameraClearFlags.Depth change was committed at 446226d |
I'm not so sure about suggestion (2) to add D3DUSAGE_DYNAMIC inside CreateVolumeTexture and CreateCubeTexture. This MSDN page says:
However, I can also see that it may be needed in order that they can be locked as described here, as that was obviously possible for the original D3D_MANAGED pool used by Unity. It also seems there may be a risk of increasing memory usage with this change, for example: OGRE issue and @Jonathan Mee's comment here However, I don't know enough about the low level behaviour of Direct3D to be sure, so please let me know if you have more information and particularly if this would fix an issue for you. It could always be made into another configuration option of course. Best regards |
I'm not sure if adding "Usage |= D3DUSAGE_DYNAMIC;" is necessary. d3d: failed to lock level 0 of face 0 of cubemap 29 [invalid call] |
Thanks. As Unity is logging errors, that confirms they need to be locked. I've therefore committed your suggested changes at 028993f. |
Hi Jam,
Are you still working on this? I tried your code in Unity5.3+ and then I opened "intercept.log", not found "Stereo enabled" which I can find within Unity4.5.1f1.
The text was updated successfully, but these errors were encountered: