make sure builds don't fail due to change in gonum #10
Conversation
fixes an issue caused by gonum/gonum@16f4144
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
+ Coverage 88.37% 88.4% +0.02%
=========================================
Files 9 9
Lines 826 828 +2
=========================================
+ Hits 730 732 +2
Misses 71 71
Partials 25 25
Continue to review full report at Codecov.
|
|
Sorry, the actual commit was gonum/gonum@5d5638e#diff-ec91e1862f48b77650f8a609837f895d |
dimreduction.go
Outdated
| @@ -186,7 +186,9 @@ func (p *PCA) Transform(m mat.Matrix) (mat.Matrix, error) { | |||
|
|
|||
| //var proj mat.Dense | |||
| var proj sparse.CSR | |||
| proj.Mul(m.T(), p.pc.VectorsTo(nil).Slice(0, r, 0, p.K)) | |||
| dst := mat.Dense{} | |||
There was a problem hiding this comment.
Could you please use the form:
var dst mat.Dense
to initialise dst.
There was a problem hiding this comment.
Do you want it grouped with the proj declaration?
| dst := mat.Dense{} | |
| var ( | |
| proj sparse.CSR | |
| dst mat.Dense | |
| ) |
There was a problem hiding this comment.
I've gone ahead and committed the changes. I left the variables ungrouped to be consistent with your other declarations.
make sure variable declaration is consistent
|
Thanks! |
|
Brilliant, thanks a lot! |
fixes an issue caused by
gonum/gonum@16f4144