Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create operation for images with tags #12

Merged
merged 4 commits into from
Aug 9, 2015

Conversation

james-nesbitt
Copy link
Owner

Issue: #9

The coach image identification process was modified to allow some centralized image name generation, but the refactored operations did not take into account intentional tags in image names. This patch fixes that:

  1. create: if you have a Config: Image: {image}:{tag} it should work now
  2. pull: pays attention to image tags
  3. destroy: pays attention to imate tags
  4. if you add a Config: Image: {image}:{tag} to a node that has a buildpath, the config value is used, with it's tag.

james-nesbitt added a commit that referenced this pull request Aug 9, 2015
Fix create operation for images with tags
@james-nesbitt james-nesbitt merged commit 8e59d11 into master Aug 9, 2015
@james-nesbitt james-nesbitt deleted the createwithimageversion branch August 20, 2015 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant