Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added profiler deletion functionality and profile existence check #2

Closed
wants to merge 1 commit into from

Conversation

Akkii4
Copy link

@Akkii4 Akkii4 commented May 12, 2023

This commit modifies the removeProfile function in the SBT contract to add a check for the existence of the profile before removing it, to avoid caller's further gas consumption for non-existing profile. Additionally, the function now removes the _profiler address from the profiles list for _soul.

This commit modifies the removeProfile function in the SBT contract to add a check for the existence of the profile before removing it, to avoid caller's further gas consumption for non-existing profile. Additionally, the function now removes the _profiler address from the profiles list for _soul.
@jamesbachini
Copy link
Owner

Added in the update with the exception of the for loop as I wasn't sure if this would create an attack vector for a DOS attack if this loop got too big. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants