Methods for determining the variant type #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James,
I added a bunch of new methods (and associated tests) for assessing the
type
(e.g. "snp", "indel", "unknown") andsub_type
(e.g., "ts", "tv", "ins", "del") of a variantRecord
. These attributes depend on some helper functions that I added:is_snp
,is_indel
,is_transition
,is_deletion
. Future work will be to support SVs.I hope this helps. Let me know if you have any comments or concerns.