Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FakeRedisMixin.from_url for unix sockets #306

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Fix FakeRedisMixin.from_url for unix sockets #306

merged 1 commit into from
Aug 27, 2021

Conversation

jherbel
Copy link
Contributor

@jherbel jherbel commented Aug 23, 2021

fakeredis.FakeRedisMixin.from_url is broken for unix sockets.
fakeredis.FakeRedis.from_url("unix://a/b/c") results in
TypeError: init() got an unexpected keyword argument 'path'
This was caused by PR #304.

bmerry
bmerry requested changes Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@bmerry bmerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good (assuming it passes the tests, which I've just kicked off) - can you just add a comment where you've added to _server.py to explain what the line is for.

@coveralls
Copy link

coveralls commented Aug 26, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 93.424% when pulling c1017c4 on jherbel:pr_unix_socket into 85febb4 on jamesls:master.

Fix FakeRedisMixin.from_url for unix sockets
c1017c4 
fakeredis.FakeRedisMixin.from_url is broken for unix sockets.
fakeredis.FakeRedis.from_url("unix://a/b/c") results in
TypeError: __init__() got an unexpected keyword argument 'path'
This was caused by PR #304.
@jherbel jherbel requested a review from bmerry August 27, 2021 06:29
@jherbel
Copy link
Contributor Author

jherbel commented Aug 27, 2021

Thanks for the reply, I have added a comment.

@bmerry bmerry merged commit d636b71 into jamesls:master Aug 27, 2021
@bmerry
Copy link
Collaborator

bmerry commented Aug 27, 2021

Thanks for the fix!

@jherbel jherbel deleted the pr_unix_socket branch August 27, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmerry bmerry bmerry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jherbel @coveralls @bmerry