Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can RoleSessionName be made configurable? #1127

Closed
james-hu opened this issue Aug 4, 2023 · 5 comments
Closed

Can RoleSessionName be made configurable? #1127

james-hu opened this issue Aug 4, 2023 · 5 comments

Comments

@james-hu
Copy link
Contributor

james-hu commented Aug 4, 2023

Thank you for making this package, it is quite handy!
I just want to propose making RoleSessionName configurable. This is the informaiton passed from the caller through IAM to the service.

It seems quite easy to mak it configurable. Basically just need to change

      new AssumeRoleCommand({
        RoleArn: this.options.roleArn,
        RoleSessionName: "axios",
      })

to

      new AssumeRoleCommand({
        RoleArn: this.options.roleArn,
        RoleSessionName: this.options.roleSessionName || "axios",
      })
@jamesmbourne
Copy link
Owner

Hey @james-hu, thanks for the suggestion! If you're able to create a PR for this I'd be happy to review it.

james-hu added a commit to james-hu/aws4-axios that referenced this issue Aug 8, 2023
@james-hu
Copy link
Contributor Author

james-hu commented Aug 8, 2023

Here's the PR: #1140

jamesmbourne added a commit that referenced this issue Aug 16, 2023
…eSessionName option (#1140)

Co-authored-by: James Bourne <jamesmbourne@users.noreply.github.com>
jamesmbourne added a commit that referenced this issue Aug 16, 2023
…leSessionName option (#1140)

Co-authored-by: James Bourne <jamesmbourne@users.noreply.github.com>
@jamesmbourne
Copy link
Owner

This should be released in v3.3.0, thanks for the contribution @james-hu!

@jamesmbourne
Copy link
Owner

@all-contributors please add @james-hu for code

@allcontributors
Copy link
Contributor

@jamesmbourne

I've put up a pull request to add @james-hu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants