Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "disabled" property to mute errors when calling VIs manually #25

Closed
joerghampel opened this issue Jun 11, 2017 · 3 comments
Closed

Comments

@joerghampel
Copy link
Contributor

If I call my build VIs manually, either directly from the development environment or via my build GUI, the "Start CLI Interface.vi" throws an error (scan from string fails because list of parameters is empty). What I would like to be able to do is tell the CLI interface that it should just ignore all following calls and not throw any errors, so I don't have to disable all of the occurances of the "Write String.vi"s all over my code.
cli-state

@JamesMc86
Copy link
Collaborator

  1. Definitely, have a better handling of the connect case to give a specific error and perhaps a Boolean flag you can work from.
  2. I am slightly concerned about having the API disable itself in the case of a failed connection. Whilst I appreciate it would be more convenient if it did, this feels like something that would be better handled at the application layer.

Happy to get the opinion of others though, is this something that makes sense to have in the library (point 2)?

@joerghampel
Copy link
Contributor Author

joerghampel commented Jun 12, 2017

I didn't mean it should disable itself automatically, my thought was to have just the property inside the class so I can set it whenever I want.

I can see two alternatives for me: Wrap all "Write String.vi"s into a subVI with a case structure inside (but I still would have to wire the CLI reference and the enable/disable info), or create a child class that implements the disable feature.

What would you suggest?

@joerghampel
Copy link
Contributor Author

As per our discussion yesterday, I will implement a wrapper class for the functionality I'd like to see. It will enable me to either output to the command line if called via CLI or to a GUI if called from my LabVIEW build tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants