New Monitor: remote queries via ssh #1398
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks! I'm away until next week so won't be able to take a proper look at this until then - I'm not ignoring it :) |
| # extract and cast the actual value | ||
| command_result = stdout.read().decode("utf-8") # let's hope for the best | ||
| client.close() # it's only now that we are done with the client | ||
| actual_value = re.match(self.regex, command_result).groups()[0] |
There was a problem hiding this comment.
I was wondering if it would be better to require a named group in the regexp, so that can be picked out specifically rather than requiring the user to craft a regexp which makes the first capturing group the one they need?
There was a problem hiding this comment.
I can do that but what would be the value of several capturing groups? There is just one that will be used anyway.
simplemonitor/Monitors/remote_ssh.py
Outdated
| if test_succeeded: | ||
| return self.record_success(self.success_message.format(actual_value)) | ||
| else: | ||
| return self.record_fail(f"actual value: {actual_value} | operator: {self.operator} | target value: {self.target_value}") |
There was a problem hiding this comment.
Any value in letting the user also customise the failure message in a similar fashion to the success one?
There was a problem hiding this comment.
This will require some adjustments - I will have to test how doable it is to pass the format to the actual logging message (right now there is just one "placeholder" ({}) for actual_value in the configuration string)
|
I just bumped the version of parakimo on the develop branch btw (finally merged dependabot's PR) |
done in f5bb0ef |
This is a preliminary PR for a new Monitor that uses SSH to connect to a remote machine, run a command, parse it results to extract a value which is then monitored.
Why preliminary?
matchwhich is a Python 3.10+ feature. I will make it retro-compatible with 3.7 as a new branch when this PR is tested/reviewed, awaiting for Simplemonitor to be, someday, bumped to 3.27 (EBV - Expected Bump Version)Important note for @jamesoff : I had to change in
envconfig.pyConfigParsertoRawConfigParserotherwise the regex I read in was escaped (see the commit). I do not think it changes anything because as far as I could tell you do not rely on escaping when reading the configuration.So try it out (
git checkout monitor_remote_ssh) and let me know!