Changes to handle GTFS static data for MTA buses #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, looks great! Really appreciate the unit testing too. Thank you! I strongly agree with the overall philosophy that we should not be strict when parsing data from transit agencies. We should make the best out of what the agency sends us. It makes me think that we should perhaps always trim whitespace in the CSV files. But this change would have larger implications, so perhaps we can wait to see if the whitespace issue appears in other fields or agency data feeds, and then consider such a bigger change. |
|
Thanks for the review! When you have time, could you also create a new release? I would like to potentially send a PR soon to integrate the MTA buses into Transiter, which will require this change. |
|
Done! |
jamespfennell
added a commit
to jamespfennell/transiter
that referenced
this pull request
Mar 27, 2023
Currently for async installs, the system is not marked as failed but instead as installing. The bug is that the transaction function to mark the system as failed returns the install error, so psql rolls back the transaction. We instead need to return nil, so that the status change is commited. This bug manifested as a client hang on a failed install which is pretty bad. I discovered this while trying out the new MTA buses config that cedarbaum@ wrote. Install of this system fails as expected because of a seperate bug in the GTFS library that was fixed by cedarbaum@ in jamespfennell/gtfs#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 changes to handle the GTFS data provided for MTA buses: http://web.mta.info/developers/developer-data-terms.html#data
transfers.txtfile optional, as this is not included.stop_lat/stop_loninstops.txt.Though these changes are in response to idiosyncrasies in the MTA bus static data, I believe they are generally useful for parsing in general, and thus are not so specific as to warrant an extension.