Add extension for MTA buses #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tripId := trip.Trip.GetTripId() | ||
| vehicleId := trip.Vehicle.GetId() | ||
| direction := trip.Trip.GetDirectionId() | ||
| compositeTripId := strings.Replace(fmt.Sprintf("%s_%s_%d", tripId, vehicleId, direction), " ", "_", -1) |
There was a problem hiding this comment.
On a related note, I think with this code the Trip ID may now vary across the trip? Like initially the trip won't have a vehicle assigned. Then when a vehicle is assigned, the trip ID will change. In Transiter this will result in any existing data for the trip being deleted when the ID change happens. I think this is totally fine (and we can always change it down the line) but just mentioning it anyway.
There was a problem hiding this comment.
This is a great point - I think truly tracking a trip end-to-end will be tricky with this feed's structure unfortunately 🙃.
cedarbaum
force-pushed
the
mta_buses_extension
branch
from
3aea89e
to
753ee6f
Compare
|
Thanks for new commits! |
jamespfennell
added a commit
to jamespfennell/transiter
that referenced
this pull request
Mar 29, 2023
...to incorporate jamespfennell/gtfs#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extension for MTA bus GTFS realtime data which transforms the
TripIds to be a combination of (1) the originalTripId, (2) theVehicleIdand (3) theDirectionId. This is an attempt to ensure thatTripIds are unique so they can be followed accurately between updates.