Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the icons we are using locally #5

Merged
merged 4 commits into from
Feb 23, 2013
Merged

Keep the icons we are using locally #5

merged 4 commits into from
Feb 23, 2013

Conversation

rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Feb 10, 2013

This will make it easier to run on Mac / Windows than having to
install the whole tango-icon-theme to /usr/share/icons/Tango

This will make it easier to run on Mac / Windows than having to
install the whole tango-icon-theme to /usr/share/icons/Tango
@jamesremuscat
Copy link
Owner

Before we pull the dependency on /usr/share/icons/Tango the icons used in CameraControl will also need copying.

I'm also not sure what the licensing implications are, but happy to do this in principle.

@rjmunro
Copy link
Contributor Author

rjmunro commented Feb 11, 2013

@jamesremuscat I've grepped the whole code for Tango icons, and hopefully got them all. I've also added a README citing their source.

We probably need to make the licensing clearer for the whole project in the general README.

@jamesremuscat
Copy link
Owner

Project licensing is something I'm thinking about.

You seem to have committed broken symlinks in a few cases, rather than actual svg files... ;) https://github.com/staldates/aldatesx/commit/bf5648836e85f1e8a467f5cbdb767eb554899b0b

We should update the code to use these versions directly.
@rjmunro
Copy link
Contributor Author

rjmunro commented Feb 11, 2013

@jamesremuscat That's because you used symlinks, not real icons. Fixed now, but we should change the code to use the real things with their original names.

jamesremuscat added a commit that referenced this pull request Feb 23, 2013
@jamesremuscat jamesremuscat merged commit f9988da into jamesremuscat:master Feb 23, 2013
@rjmunro rjmunro deleted the feature/keep-icons-local branch February 25, 2013 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants