Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.1.6.10 - Rollup Conductor tweaks #554

Merged
merged 8 commits into from
Jan 18, 2024
Merged

v.1.6.10 - Rollup Conductor tweaks #554

merged 8 commits into from
Jan 18, 2024

Conversation

jamessimone
Copy link
Owner

… used to start up the async portion of Apex Rollup
jamessimone and others added 2 commits January 16, 2024 10:06
Bumps [@salesforce/sfdx-scanner](https://github.com/forcedotcom/sfdx-scanner) from 3.19.0 to 3.20.0.
- [Release notes](https://github.com/forcedotcom/sfdx-scanner/releases)
- [Commits](forcedotcom/sfdx-scanner@v3.19.0...v3.20.0)

---
updated-dependencies:
- dependency-name: "@salesforce/sfdx-scanner"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…r starting up Apex Rollup, as that particular batch class is NOT stateful and changes made to it in start() are not persisted in finish() - to get around this, when apex rollup is started up async but the only processors included are themselves full recalc operations, the start() method now conditionally checks to see if it needs to do a one-time match on Organization, which allows the full recalc processors to be properly invoked within the execute() method (instead of skipping straight from start() to finish() due to all of the full recalc processors being winnowed out)
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (431a5b6) 96.53% compared to head (183369f) 96.60%.

❗ Current head 183369f differs from pull request most recent head fe9f11c. Consider uploading reports for the commit fe9f11c to get more accurate results

Files Patch % Lines
rollup/core/classes/RollupAsyncProcessor.cls 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   96.53%   96.60%   +0.07%     
==========================================
  Files          32       32              
  Lines        6720     6725       +5     
  Branches       61       61              
==========================================
+ Hits         6487     6497      +10     
+ Misses        228      223       -5     
  Partials        5        5              
Flag Coverage Δ
Apex 96.84% <95.65%> (+0.08%) ⬆️
LWC 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamessimone jamessimone merged commit 4e43d71 into main Jan 18, 2024
1 check passed
@jamessimone jamessimone deleted the v1.6.10 branch January 18, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollupAsyncProcessor is creating a second queueable job per apex invocation
2 participants