Expose the Express app on S3rver instances #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamhall Any comment on this? edit: I just noticed that my issue is only present when using it as a mountable express app. The command line version already has |
This also reduces redundant code by dynamically creating the setter methods for the S3rver class.
kherock
changed the title
|
OK, I've figured out a better solution since the problem was just that certain default options aren't set when you try to use the Express app via |
|
Closing since I'll include these changes in a less intrusive manner in #63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fs option added in #54 wasn't documented and was a breaking change, so I was pretty confused what was wrong for a bit. Using
fs-extraby default makes it non breaking : ).