-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, short-circuiting #4
Conversation
Did your test app have much in it, or just a call to |
This looks great @lorensr! I'll take a better look tomorrow. Test app was just a manual testing app. |
tests don't work, waiting on meteor/guide#401 |
actually probably a different problem: |
tests working, would you like to add to them? |
production-ready packages have tests and changelogs 😉 😄 good thing we're past 1.3 and don't have to use tinytest! https://github.com/lorensr/login-links/blob/master/tests/client/connectionLogin.js |
You're a star! I'm just finishing up some contract work and merging all this is next on my list. |
Thanks! It was enough changes that I wouldn't publish until more tests are written or it's re-manually tested |
Not ready to merge, I haven't tested yet. Probably even has syntax errors 😜
Changes are more intelligible if you look at individual commits.
Reloader.reload()
so we can keepreloaderWasRefreshed
accurate.launchScreenDelay
this
, and now it's easier to see what's going on at the top level at the bottom of the filetakes longer to read and understand than this:
a lot of readbility has to do with naming and structure (
handle
->launchScreen
). similarly, note how I extracted out pieces of code, or compound booleans, into functions with names that were descriptive enough that no comment was necessary.