feat: only add new files to Xcode Colocated group #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves issue jamonholmgren#14 by removing from the project those files from an existing Colocated group that do not exist anymore and are not included in the `colocated_files` array, keeping in the `colocated_group` the ones that are already linked. In the next iteration of `colocated_files`, the iteration is skipped if the file already belong to `colocated_group`, otherwise it is added.
|
FYI I solved conflicts with ChatGPT 4. Here's the transcript: https://aiarchives.org/id/RM7epr9Q8dTdt0e4Cewd |
Lovely! |
|
I reworked on it in #19 as I missed an issue based on how paths are handled. Sorry about that, I thought I tested it previously |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-06-20) ### Bug Fixes * Bump yarn.lock maybe? ([69fcd60](69fcd60)) * **ios:** Detects colocated files already existing using realpath ([#19](#19)) ([fda76ff](fda76ff)), closes [#18](#18) * Testing CI ([54f6438](54f6438)) ### Features * **Xcode:** add support for monorepo & exclude_targets ([#13](#13) by [@ste7en](https://github.com/ste7en)) ([5437590](5437590)) * **Xcode:** only add new files to Colocated group - fixes [#14](#14) ([#16](#16) by [@ste7en](https://github.com/ste7en)) ([62ecf76](62ecf76))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #14 by removing from the project those files from an existing Colocated group that do not exist anymore and are not included in the
colocated_filesarray, keeping in thecolocated_groupthe ones that are already linked. In the next iteration ofcolocated_files, the iteration is skipped if the file already belong tocolocated_group, otherwise it is added.