Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only add new files to Xcode Colocated group #16

Merged

Conversation

ste7en
Copy link
Contributor

@ste7en ste7en commented Mar 14, 2023

This solves issue #14 by removing from the project those files from an existing Colocated group that do not exist anymore and are not included in the colocated_files array, keeping in the colocated_group the ones that are already linked. In the next iteration of colocated_files, the iteration is skipped if the file already belong to colocated_group, otherwise it is added.

This solves issue jamonholmgren#14 by removing from the project those
files from an existing Colocated group that do not exist
anymore and are not included in the `colocated_files` array,
keeping in the `colocated_group` the ones that are already linked.
In the next iteration of `colocated_files`, the iteration is
skipped if the file already belong to `colocated_group`,
otherwise it is added.
Copy link
Owner

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jamonholmgren jamonholmgren merged commit 62ecf76 into jamonholmgren:main May 25, 2023
@jamonholmgren
Copy link
Owner

FYI I solved conflicts with ChatGPT 4. Here's the transcript: https://aiarchives.org/id/RM7epr9Q8dTdt0e4Cewd

@ste7en
Copy link
Contributor Author

ste7en commented May 26, 2023

FYI I solved conflicts with ChatGPT 4. Here's the transcript: https://aiarchives.org/id/RM7epr9Q8dTdt0e4Cewd

Lovely!

@ste7en
Copy link
Contributor Author

ste7en commented May 26, 2023

I reworked on it in #19 as I missed an issue based on how paths are handled. Sorry about that, I thought I tested it previously

github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-06-20)

### Bug Fixes

* Bump yarn.lock maybe? ([69fcd60](69fcd60))
* **ios:** Detects colocated files already existing using realpath ([#19](#19)) ([fda76ff](fda76ff)), closes [#18](#18)
* Testing CI ([54f6438](54f6438))

### Features

* **Xcode:** add support for monorepo & exclude_targets ([#13](#13) by [@ste7en](https://github.com/ste7en)) ([5437590](5437590))
* **Xcode:** only add new files to Colocated group - fixes [#14](#14) ([#16](#16) by [@ste7en](https://github.com/ste7en)) ([62ecf76](62ecf76))
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants