cfa: Fix exception handling bug #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update in lavaan has caused a lot of their error messages to change. Because we catch a couple of exceptions based on these messages, some of the error were not caught anymore. This also cause one unit test to fail, flagging `jmv` for removal by CRAN. To fix this, the message that we use to catch the error, was changed so that it's compatible with both old and new versions of lavaan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update in lavaan has caused a lot of their error messages to change. Because we catch a couple of exceptions based on these messages, some of the error were not caught anymore. This also cause one unit test to fail, flagging
jmvfor removal by CRAN. To fix this, the message that we use to catch the error, was changed so that it's compatible with both old and new versions of lavaan.