This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Felicia/dis 1592 jamsocket javascript add socketio back in #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolyatmax
reviewed
Jan 29, 2024
src/client.ts
Outdated
| this.openSocket() | ||
| this._isReady = true | ||
| this._onReady.forEach((cb) => cb()) | ||
| this._onReady = [] |
There was a problem hiding this comment.
I think a rebase/merge will remove these changes from this PR (since this has already landed in main). Let me know if you run into any problems with this!
rolyatmax
reviewed
Jan 29, 2024
| @@ -13,6 +13,7 @@ | |||
| "./server": "./dist/server.js", | |||
| "./client": "./dist/client.js", | |||
| "./react": "./dist/react.js", | |||
| "./socketio": "./dist/socketio.js", | |||
There was a problem hiding this comment.
I think we need to update the examples in the README now that we've factored out the socketio stuff into its own import.
rolyatmax
reviewed
Jan 29, 2024
src/react.tsx
Outdated
| @@ -16,6 +16,7 @@ export function SessionBackendProvider({ | |||
|
|
|||
| useEffect(() => { | |||
| setBackend(new SessionBackend(url, statusUrl)) | |||
| console.log('session') | |||
paulgb
reviewed
Jan 29, 2024
src/socketio.tsx
Outdated
Comment on lines
38
to
40
| backendUrl.pathname[backendUrl.pathname.length - 1] === '/' | ||
| ? backendUrl.pathname.substring(0, backendUrl.pathname.length - 1) | ||
| : backendUrl.pathname |
There was a problem hiding this comment.
you can replace this whole expression with
const path = backendUrl.pathname.replace(/\/$/, '')
|
From the Slack convo we had - I've got a few small changes I pushed to a separate branch that I think gets things working here. You can see the changes (along with some comments) here: c73b9f3 |
|
Once this is landed, we'll want to cut a new version and publish to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.