Add HTTP API to Plane controller #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
controller/src/http_server.rs
Outdated
| cluster: ClusterName, | ||
| image: String, | ||
| ) -> Result<ScheduleRequest> { | ||
| let max_idle_secs = Duration::from_secs(self.grace_period_seconds.unwrap_or_else(|| 600)); |
There was a problem hiding this comment.
unwrap_or should be fine here, also would be good to put this in a const at the the top of the file.
controller/src/http_server.rs
Outdated
|
|
||
| impl HttpSpawnRequest { | ||
| pub fn into_spawn_request( | ||
| &self, |
There was a problem hiding this comment.
either call this as_* (is that what it wants?) or silence the clippy complaint by turning off wrong_self_convention
controller/src/http_server.rs
Outdated
| let service = server_state | ||
| .services | ||
| .get(&service) | ||
| .ok_or_else(|| StatusCode::NOT_FOUND)?; |
There was a problem hiding this comment.
should be fine to use ok_or here too
pretentious7
approved these changes
Aug 18, 2023
paulgb
deleted the
paul/dis-1221-add-a-jamsocket-compatible-http-server-to-plane-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an HTTP API that is a subset of the NATS API. It aims for compatibility with jamsocket.com, so that jamsocket users can test locally with Plane.