Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abhi/add resource limit test #534

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Abhi/add resource limit test #534

merged 5 commits into from
Jan 5, 2024

Conversation

pretentious7
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 8:27pm

@pretentious7 pretentious7 marked this pull request as ready for review January 5, 2024 15:49
paulgb
paulgb reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@paulgb paulgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, left some comments. Is the intention for #535 to be merged before this?

plane/src/drone/docker/commands.rs Outdated Show resolved Hide resolved
plane/src/drone/docker/commands.rs Outdated Show resolved Hide resolved
plane/src/drone/docker/commands.rs Outdated Show resolved Hide resolved
@pretentious7 pretentious7 merged commit 56beb7f into main Jan 5, 2024
6 checks passed
@pretentious7 pretentious7 deleted the abhi/add-resource-limit-test branch January 5, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgb paulgb paulgb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pretentious7 @paulgb