Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy clippy #784

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Satisfy clippy #784

merged 3 commits into from
Jul 12, 2024

Conversation

michaelsilver
Copy link
Member

@michaelsilver michaelsilver commented Jul 11, 2024

The only nontrivial change was switching from std::sync::Mutex to tokio::sync::Mutex because the mutex was held across calls to .await, following the official guidance from Tokio.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 5:49pm

Copy link
Member

@paulgb paulgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you run clippy so that you get these lint warnings? I'm trying to reproduce the errors here but it comes up clean on main.

plane/plane-tests/tests/common/test_env.rs Outdated Show resolved Hide resolved
Copy link
Member

@paulgb paulgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to request changes

@michaelsilver
Copy link
Member Author

How did you run clippy so that you get these lint warnings? I'm trying to reproduce the errors here but it comes up clean on main.

cargo clippy --fix

From help docs:

--fix                    Automatically apply lint suggestions. This flag implies --no-deps and --all-targets

So the problem is you were running cargo clippy when instead you should run cargo clippy --all-targets

@michaelsilver michaelsilver merged commit ad766c3 into main Jul 12, 2024
6 checks passed
@michaelsilver michaelsilver deleted the michael/dis-2285-fix-clippy-in-plane branch July 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants