-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy clippy #784
Satisfy clippy #784
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a6dd893
to
73cfe94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you run clippy so that you get these lint warnings? I'm trying to reproduce the errors here but it comes up clean on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to request changes
From help docs:
So the problem is you were running |
73cfe94
to
4713768
Compare
4713768
to
b7e1a55
Compare
The only nontrivial change was switching from
std::sync::Mutex
totokio::sync::Mutex
because the mutex was held across calls to.await
, following the official guidance from Tokio.