-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android/LineageOS: Jamulus settings don't get saved on closing app #2395
Comments
Moto G9 Power, Android 11 ("Stock" Motorola release). Freshly installed Jamulus 3.8.2rc1. Same behavour: change a setting (Fancy -> Compact), close the app normally, it's saved; change a setting (Compact -> Fancy), close the app with a swipe to clear, it's not saved. At a guess, there will be some signal sent to the app, either a *nix SIGxxx or a Qt-level one, that we can catch and process, so I'd hope it's an easy fix if someone can find the appropriate Qt/Android tech docs. |
Further, my partner reports that simply switching off the screen can cause the app to "time out" and it closes without saving then. |
Looks like we need to catch changes to state: (Same in 6.5: https://doc.qt.io/qt-6/qguiapplication.html#applicationStateChanged) Also this looks interesting - I guess we should honour the request: |
It's a nasty bug. I can only test on a VM as I don't have access to an up to date Android device at the moment. |
If there were a way of just running the Android build (and, ideally, limiting it to one architecture), I guess I could use github to produce the APK and then install that... Currently, Windows is refusing to build it and my Linux box has no access to an Android device. If I could build the APK at all, using Qt Creator, it would help... |
I mean you could probably install Qt with Android support and then set the respective configuration? |
Yes, that's what I did - following the Qt for Android guide. It gets as far as the deploy step and errors out with
|
Maybe the Java version isn't compatible (related to your issue here: #2767) Funny what pops up on searching for that (I believe that's quite low effort: https://www.youtube.com/watch?v=izHfFiEK9Jw) |
Now to find out where the tooling is setting the gradle version... hmmm... |
I'd assume it's in .github/autobuild/android.sh ? |
I don't see specific mention of gradle and it's a linux-based build, too, whereas I'm trying to work on Windows. (It's also using Java 8 and I'm trying to use Java 17... My Windows box has 8, 11 and 17 on but my linux box only 17, currently.) |
From https://github.com/jamulussoftware/jamulus/actions/runs/5104913232/jobs/9176149075 lets me believe that it's gradle 5.6.4 |
https://github.com/jamulussoftware/jamulus/actions/runs/5104913232/jobs/9176149075#step:10:1502 indeed.
I guess I need that as a dependency to build, then. I'd have expected Qt Creator to get it right, though. |
I'm keen to get this one closed for 3.11.0. |
Yes! Please note that I can only test in a VM as I don't have access to a (modern) Android device. |
Describe the bug
If you change settings in the Jamulus App and close it via the app switcher. On LineageOs it seems as if settings don't persist. Closing via File>Close does save the settings. Probably the .ini file doesn't get written if you close the app via app switcher.
To Reproduce
Expected behavior
The profile settings are saved (i.e. the ini file gets written on closing the app).
Screenshots
Operating system
Android/LineageOS 16.0
Version of Jamulus
3.8.2rc1
Additional context
This bug seems to be found some time ago by @ngocdh #1382
Maybe not all versions of Android/LineageOS are affected. Therefore someone else with another device should verify.
The text was updated successfully, but these errors were encountered: