-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Move NSIS files to libs\ #2822
Conversation
befd311
to
43abc2e
Compare
I just read the following:
Probably it's worth adding -m on the nsProcess build. |
Ok. I successfully installed JACK and ASIO build on my Win 11 machine. |
Does this need updating as well?
We want to cache the downloaded NSIS source, but not (even if we seem to...?) anything coming from our repo or any build artifacts. |
.github/workflows/autobuild.yml:317: ${{ github.workspace }}\windows\NSIS needs updating. I don't think the other ones have changed? |
Sorry, I just added the other lines for context. NSIS is what I meant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've triggered two further CI runs and observed that NSIS source caching works properly:
https://github.com/jamulussoftware/jamulus/runs/8141543452?check_suite_focus=true#step:10:48
Using D:\a\jamulus\jamulus\windows..\libs\NSIS\NSIS-source from previous run (e.g. actions/cache)
Short description of changes
Moves the NSIS files to the libs\ folder similar to ASIO-SDK. This is done to clean up the repo and simplify the structure. #2601 was the initial draft, and I plan multiple smaller PRs which are more testable.
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for testing and review.
What is missing until this pull request can be merged?
Testing. I'm a bit worried since the other PR I mentioned didn't fail, but there were some suspected issues.
Checklist