-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Move platform specific code files to src/ #2824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the basis that a clean build for all targets affected works... (Might be worth ensuring that happens...)
I'd wait until the CI is green and then test the artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, thanks. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS legacy build works as expected and shows the badge. I can NOT run the normal build, as something seems to be wrong with the universal build. It doesn't show up as universal but ARM now? |
iOS also installs and works correctly. |
Ok. Great. So I'll merge it. |
Short description of changes
Moves the platform specific code to src/
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for testing and review.
What is missing until this pull request can be merged?
Testing.. Should either compile or not compile to show if everything is working.
Checklist