Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Move platform specific code files to src/ #2824

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Aug 29, 2022

Short description of changes

Moves the platform specific code to src/

CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?

Related to: #2601

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Ready for testing and review.

What is missing until this pull request can be merged?
Testing.. Should either compile or not compile to show if everything is working.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Jamulus.pro Outdated Show resolved Hide resolved
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the basis that a clean build for all targets affected works... (Might be worth ensuring that happens...)

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2022

I'd wait until the CI is green and then test the artifacts.

@hoffie hoffie added this to the Release 3.9.1 milestone Aug 29, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks. :)

Copy link
Member Author

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoffie @pljones can one of you please test Android?

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2022

macOS legacy build works as expected and shows the badge. I can NOT run the normal build, as something seems to be wrong with the universal build. It doesn't show up as universal but ARM now?

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2022

iOS also installs and works correctly.

@pljones
Copy link
Collaborator

pljones commented Aug 29, 2022

@hoffie @pljones can one of you please test Android?

Downloaded the ZIP, downloaded an unzipper (eventually... why doesn't Android have one?!)... uninstalled Jamulus (as I always forget this wasn't immediate...)... Installed build from ZIP successfully.

@ann0see
Copy link
Member Author

ann0see commented Aug 30, 2022

Ok. Great. So I'll merge it.

@ann0see ann0see merged commit 79ea043 into jamulussoftware:master Aug 30, 2022
@ann0see ann0see deleted the move/moveCode branch August 30, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants