Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document weblate: tools and TRANSLATING.md #2880

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Sep 23, 2022

Short description of changes

Document Weblate in Translating.md and tools script. Also added adding a new language - although it's strictly speaking not weblate related. However, it's based on the changes, so adding it as separate commit.

CHANGELOG: Translation: Document translation process shift to Weblate. Translators can from now one use Weblate for translations.

Context: Fixes an issue?

Fixes: #2758 (at least I think that's the last todo?)

Does this change need documentation? What needs to be documented and how?

No. Hopefully that's all

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see linked an issue Sep 23, 2022 that may be closed by this pull request
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
@ann0see
Copy link
Member Author

ann0see commented Sep 25, 2022

@henkdegroot you might want to have a look at this as you commented on #2758 (comment)

docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
docs/TRANSLATING.md Outdated Show resolved Hide resolved
ann0see pushed a commit to ann0see/jamulus that referenced this pull request Oct 9, 2022
Related to: jamulussoftware#2880 (comment)
Co-authored-by: mcfnord <mcfnord@users.noreply.github.com>
@ann0see ann0see requested a review from mcfnord October 9, 2022 20:23
docs/TRANSLATING.md Outdated Show resolved Hide resolved
ann0see pushed a commit to ann0see/jamulus that referenced this pull request Oct 10, 2022
Related to: jamulussoftware#2880 (comment)
Co-authored-by: mcfnord <mcfnord@users.noreply.github.com>
docs/TRANSLATING.md Outdated Show resolved Hide resolved
ann0see pushed a commit to ann0see/jamulus that referenced this pull request Oct 20, 2022
Related to: jamulussoftware#2880 (comment)
Co-authored-by: mcfnord <mcfnord@users.noreply.github.com>
@ann0see
Copy link
Member Author

ann0see commented Oct 20, 2022

I'd like to get this in soon.

@ann0see ann0see requested review from pljones and hoffie and removed request for mcfnord October 20, 2022 19:22
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking but that one minor one if you like.
https://github.com/jamulussoftware/jamulus/pull/2880/files#r989471694

ann0see and others added 4 commits October 20, 2022 23:38
Co-authored-by: ignotus666 <ignotus666@users.noreply.github.com>
Co-authored-by: comradekingu <comradekingu@users.noreply.github.com>
Co-authored-by: comradekingu <comradekingu@users.noreply.github.com>
Fixes: jamulussoftware#2755
Co-Authored-By: comradekingu <comradekingu@users.noreply.github.com>
Co-Authored-By: mcfnord <mcfnord@users.noreply.github.com>
Related to: jamulussoftware#2880 (comment)
Co-authored-by: mcfnord <mcfnord@users.noreply.github.com>
@ann0see ann0see merged commit 1820d66 into jamulussoftware:master Oct 20, 2022
@ann0see ann0see deleted the documentWeblate branch October 20, 2022 21:41
ann0see pushed a commit to ann0see/jamulus that referenced this pull request Nov 9, 2022
Related to: jamulussoftware#2880 (comment)
Co-authored-by: mcfnord <mcfnord@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Using Weblate for translations Document adding a new language
6 participants