-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: iOS: Use Qt6 and bump build environment #3065
Changes from all commits
cec7148
f097dc4
3b6d500
3e96f6b
7865882
f4c02de
6e721f5
f211c66
25a0bc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,6 +53,11 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP, CClientSettings* pNSet | |
layout()->setMenuBar ( pMenu ); | ||
#endif | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Smells like avoidable duplication. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we live with this for now as it's not directly related? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated, but worth an issue |
||
|
||
#if defined( Q_OS_ANDROID ) || defined( ANDROID ) || defined( Q_OS_IOS ) | ||
// for the Android/iOS version maximize the window | ||
setWindowState ( Qt::WindowMaximized ); | ||
#endif | ||
|
||
// Add help text to controls ----------------------------------------------- | ||
// local audio input fader | ||
QString strAudFader = "<b>" + tr ( "Local Audio Input Fader" ) + ":</b> " + | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,8 +151,8 @@ CConnectDlg::CConnectDlg ( CClientSettings* pNSetP, const bool bNewShowCompleteR | |
// setup timers | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if the order we set the maximized state matters. At least in the version which kind of worked - I first needed to rotate the screen to allow it getting the correct sizing - but that's way better than it was. |
||
TimerInitialSort.setSingleShot ( true ); // only once after list request | ||
|
||
#ifdef ANDROID | ||
// for the android version maximize the window | ||
#if defined( Q_OS_ANDROID ) || defined( ANDROID ) || defined( Q_OS_IOS ) | ||
// for the Android/iOS version maximize the window | ||
setWindowState ( Qt::WindowMaximized ); | ||
#endif | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like eval here