Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End time doesn't update while watching recording in progress #30

Closed
ibishop100 opened this issue Feb 1, 2016 · 11 comments
Closed

End time doesn't update while watching recording in progress #30

ibishop100 opened this issue Feb 1, 2016 · 11 comments

Comments

@ibishop100
Copy link

As the title. While watching a recording in progress, the end time of the show doesn't update.

To duplicate:

  • Create a recording in mythtv
  • Wait until it has recorded some period of time
  • Start playback of that recording
  • Fast forward, end time will not update

Expected behaviour:

  • Similar to mythfrontend, the time display updates as the recording progresses

This is a great addon, stable and works very well, having this fixed would take away one of those annoyances.

@janbar
Copy link
Owner

janbar commented Feb 2, 2016

What do you mean by end time ?
Is it the end time of epg program, or current end time of recorded ?
Actually backend doesn t provide current end time of recorded, but only file size. But it is possible to estimate an recorded end comparing current time with recording rule end time.

@janbar
Copy link
Owner

janbar commented Feb 2, 2016

I guess you mean current recorded end time. I will check it soon but i think addon provides this estimated end time today.

@ibishop100
Copy link
Author

End time is probably a misleading term. I mean the current recorded amount. So I can see how much more of the program that is playing has been recorded. Most commonly I use it while watching a hockey game, so I know how much more I can skip. As I get closer to the end I can decide to take a break, watch something else, etc.

Assume I let a recording go for 52:21, when I start playing, the position will be 00:00:00 - 00:52:21. As I watch and fast forward commercials the current position updates, but the 00:52:21 never does.

Mythfrontend updates this end time seemingly in realtime, at least every second. It's also nice as a reassurance that the recorder is still working, and a reminder to add more time if a program seems like it might go long.

@janbar
Copy link
Owner

janbar commented Feb 7, 2016

So, this behavior is not due to the addon. Currently kodi don't care if recording is recording and so it doesn't update the end time. I know it was a feature request and seems it has been discarded from jarvis release. Really it shouldn't be hard to enable this feature because we have to check end time isn't over. Please could you ask on the pvr forum for this feature ?

@ImNtReal
Copy link

ImNtReal commented Jul 7, 2016

Did this ever get requested elsewhere? I'm also interested in this. Should it be requested under https://github.com/kodi-pvr/pvr.mythtv or somewhere else?

@ImNtReal
Copy link

ImNtReal commented Jul 7, 2016

After some research, I found this Trac ticket: http://trac.kodi.tv/ticket/13309 linked from this forum post: http://forum.kodi.tv/showthread.php?tid=159681. The ticket was closed as won't fix, and pointed the finger at pvr code.

@ibishop100
Copy link
Author

Hi Jameson, I got busy, then forgot to follow up. I haven't done anything
about this. If you could request this of the PVR devs that would be
awesome. That other thread and ticket you referenced had nothing to do
with pvr as that guy was just accessing his recordings as files over NFS.

Long live Mythtv!

On 6 July 2016 at 18:26, Jameson Pugh notifications@github.com wrote:

After some research, I found this Trac ticket:
http://trac.kodi.tv/ticket/13309 linked from this forum post:
http://forum.kodi.tv/showthread.php?tid=159681. The ticket was closed as
won't fix, and pointed the finger at pvr code.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AP76iog7IADzmcm1TeS5XM-hhFj_iRFMks5qTFXdgaJpZM4HQ0wI
.

@ibishop100
Copy link
Author

As Jean-Luc said it needs to be requested of the main Kodi devs, I guess
through the pvr forums. If you request it, update this thread with a link
and I'll follow along, help where I can.

On 6 July 2016 at 18:34, Ian Bishop ibishop@gmail.com wrote:

Hi Jameson, I got busy, then forgot to follow up. I haven't done anything
about this. If you could request this of the PVR devs that would be
awesome. That other thread and ticket you referenced had nothing to do
with pvr as that guy was just accessing his recordings as files over NFS.

Long live Mythtv!

On 6 July 2016 at 18:26, Jameson Pugh notifications@github.com wrote:

After some research, I found this Trac ticket:
http://trac.kodi.tv/ticket/13309 linked from this forum post:
http://forum.kodi.tv/showthread.php?tid=159681. The ticket was closed as
won't fix, and pointed the finger at pvr code.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AP76iog7IADzmcm1TeS5XM-hhFj_iRFMks5qTFXdgaJpZM4HQ0wI
.

@knappster1
Copy link

@janbar I see that this issue is still open and I am experiencing it in 5.8.7 on kodi 18 beta 3. Interestingly, I notice that if I watch a 1 hour program on livetv, it shows that I am, for example 5 minutes into a 1 hour recording. However, if I am recording a 1 hour show and playback the recording 5 minutes after it starts recording, then it will show that I am at the beginning of a 5 minute recording. This wouldnt be such a nuisance, but if I try to skip after the 5 minute mark, it will go back to the first 5 minutes.

It seems that a workaround would be to process the length of the recording the same way as live tv, so that the length is estimated based on the recording schedule. Maybe I am oversimplifying things?

@janbar
Copy link
Owner

janbar commented Oct 21, 2018

@knappster1 , you are right: the new API for Leia uses the same way to retrieve timeshift info even for recordings. This Issue is fixed by the commit 9686b9f.

@janbar janbar closed this as completed Oct 21, 2018
@knappster1
Copy link

@janbar , thanks. I've updated to 5.8.10 now and can confirm that this is working dynamically now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants