Improved Timer Display and Management

[metaron-uk]

Timers created in mythweb / mythfrontend with 'Any Channel' currently show as multiple entries in the Timers list: one entry for each 'repeat' on each channel, most of which are disabled.
Before:

This PR hides timers relating to 'earlier', 'later' and 'already in the library' recordings.
Optionally (using client "Show/hide rules with status 'Not Recording'") 'previously recorded but no longer in library' timers can be shown as 'disabled'.

Some bugs preventing the deletion of advanced rules and over-ride (active/inactive) were squashed and 'repeating' attributes were disabled to make the Timers list easier to read.

After:

Other benefits:
Currently recording and Next recording now show what will record and not the disabled alternatives
EPG only shows timer icons for what will actually record, not things which won't.

I believe this makes the Timers screen more usable for helix and Isenguard until proper series recording rule support arrives (hopefully in Jxxxxxx).

[janbar]

Thanks metaron-uk. I am testing it.

[janbar]

So finally, no more need addition of getter MythScheduleManager::GetShowNotRecording(). It can be removed from the PR.

[janbar]

Great work. I'm looking forward you rebase the PR. Please remove trailing whitespace and you could make 3 commits in order

• first including changes on MythProgramlInfo.h and .cpp
• second including changes on MythScheduleManager.h and .cpp
• third including changes on pvrclient-mythtv.cpp

Thanks @metaron-uk

[metaron-uk]

@janbar
I've incorporated your feedback and rebased the commit as requested.

After more testing I decided making a special case for over-ride rules when 'show not recording' was enabled was confusing. The user now gets a display similar to mythweb with all the boxes ticked (Scheduled, Duplicates/Ignored, Deactivated, Conflicts).

With 'show not recording' disabled (the default), the display is like mythweb with 'Duplicates/Ignored' and 'Deactivated' turned off until you set an over-ride rule.
With over-ride rules present the Timers window will show the 'Disabled' time slots deactivated by the over-ride as well as the enabled time slot. This makes it more obvious an over-ride is in place.

I have two extra questions / suggestion:

1. Should the 'show not recording' setting be saved in the config file? (I can add this if you want)
2. The title 'Show/hide rules with status 'Not Recording' is confusing. You don't know what you will get when selecting the option. Would it be easy to change the title between "Show rules with status 'Not Recording" and "Hide rules with status 'Not Recording'", or maybe show a radio button or show current status in some other way? I haven't tackled this one as it would probably require translation changes....

[janbar]

Great work.
I think this setting should be flagged off at normal startup. More the timer view is clean then more usage is easy for basic user. Important is basic things can be done by simple way: create rule , show upcoming, allow to enable/disable upcoming with override. Now the setting is toggled by a menu hook, if you prefer a radio button then we have to move it to saved settings and its default value will be off. But before i would like merge this PR because i have to merge these changes with my development for API 1.9.7, and probably i will add a new tab in settings to group all options about timer. I will let you know.

[janbar]

Thanks

[metaron-uk]

Many thanks to you for an excellent PVR client and good luck with API 1.9.7!
If you need any help testing, let me know.

I'm not sure how 'Don't Expire', 'Record New and Expire Old' and 'No Recordings to Keep' will fit into the API (http://forum.kodi.tv/showthread.php?tid=227026&pid=2029531#pid2029531), but everything else I would want apart from Recording Groups seems to already have a home. I hope my PR for Ksooo to add a 'Folder List' to the API makes the final version.

[janbar]

@metaron-uk , I will publish soon my first draft running with API 1.9.7, and you could propose some changes to add or fix some point of view.