Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum brightness #99

Closed
Welsyntoffie opened this issue Aug 27, 2022 · 8 comments
Closed

Minimum brightness #99

Welsyntoffie opened this issue Aug 27, 2022 · 8 comments

Comments

@Welsyntoffie
Copy link

I am not finding any references to minimum brightness for the breathing effect.
Currently LED's turn off then fades on again. I would like to set a minimum brightness.
Is that possible?

@jandelgado
Copy link
Owner

Not yet, will add the feature soon.

@Welsyntoffie
Copy link
Author

Thats great news, thank you.

@sauresahne
Copy link

Just stumbled upon this through Hackaday, Wonderful library, thanks.
That enhancement sounds great. I am going to use it for a bike light.

To summarize the great-rear-light-blinking-debate:
Opinion 1: A blinking rear light gives you more attention from other drivers.
Opinion 2: A steady rear light helps other people in judging distance and your speed. Blinking interferes with that. If a blinking light is your only rear light, other drivers can see you, but not always locate you precisely.

So, yeah. Being able to set a constant led brightness with a blink or breath on top would be really great.

@jandelgado
Copy link
Owner

Released with 4.12.0 https://github.com/jandelgado/jled/releases/tag/v4.12.0

@Welsyntoffie
Copy link
Author

Works great. Thank you.
I did notice that the stop command does not turn the led off but keeps it at the lowest set brightness. In my project I had to analogwrite=0 to completely turn off the led. But the MinBrightness does work great. Closing this issue

@jandelgado
Copy link
Owner

Good Point. Will think about it over the holidays. I think it would still be good to be able to turn a LED fully off with Stop, perhaps by adding an optional parameter.

@jandelgado
Copy link
Owner

fyi @Welsyntoffie: with JLed Release 4.13.0 (see #121 ) it is now possible to fully turn of the LED or keep the last value with Stop().

@Welsyntoffie
Copy link
Author

Great. Thanks for info. Still going strong with my CSGO stage light strip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants