Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stop to turn led fully off regardless of min brightness #121

Conversation

jandelgado
Copy link
Owner

Calling Stop() currently the output level to whatever min brightness is set to (default is 0). However, we often to want the LED to be completely off when calling Stop()

@coveralls
Copy link

coveralls commented Aug 20, 2023

Coverage Status

coverage: 98.382% (+0.7%) from 97.653% when pulling c1defbe on allow_stop_to_turn_led_fully_off_regardless_of_min_brightness into 5b10437 on master.

@jandelgado jandelgado marked this pull request as ready for review August 20, 2023 19:33
@jandelgado jandelgado merged commit 0633121 into master Aug 20, 2023
2 checks passed
@jandelgado jandelgado mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants