Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use pypi versions of dependencies #172

Closed
wants to merge 1 commit into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Mar 18, 2024

Removes git dependencies, enabling packaging of this project on pypi. This PR is currently broken until funlib.evaluate gets added to pypi.

@d-v-b d-v-b changed the title chore: use pypi versions of dependencies [WIP] use pypi versions of dependencies Mar 18, 2024
@mzouink
Copy link
Member

mzouink commented Mar 18, 2024

@d-v-b our problem is that the published version of daisy is no longer valid.
funlib.evaluate and lsd are not published in pypi

@cmalinmayor can you please make a new release of daisy
@funkey or @pattonw can you please release funlib.evaluate and lsd

@pattonw
Copy link
Contributor

pattonw commented Mar 18, 2024

lsd is on pypi. Unfortunately the name of lsd was taken so you have to use pip install lsds.
I published a minor update to daisy. I don't think there were any breaking changes in there, mostly just performance tweaks and process cleanup. but both v1.0 and v1.1 should both be valid.
funlib.evaluate is a bit more problematic. It depends on graph_tool which is a nuisance to install and is not available on pypi.

@mzouink
Copy link
Member

mzouink commented Mar 25, 2024

@pattonw is graph_tool a mandatory dependency. seams not to be used

@mzouink
Copy link
Member

mzouink commented Mar 25, 2024

Needed:

@rhoadesScholar
Copy link
Member

See #212
funlib.evaluate removed as a dependency by removing IoU metric not previously used for evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants