Merge v0.15 changes back into master #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate <kit.ty.kate@disroot.org>
Signed-off-by: Aaron L. Zeng <me@bcc32.com>
Base hasn't supported OCaml 4.03 and earlier since v0.9 Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Signed-off-by: David Allsopp <david.allsopp@metastack.com>
…omise_no_mutation Signed-off-by: Jesse Tov <jtov@janestreet.com> Co-authored-by: hhugo <hugo.heuzard@gmail.com>
Building in dev mode was failing because `round_nearest` could not be inlined at a call from `int63_round_nearest_portable_alloc_exn` that was annotated [@ocaml.inlined always]. This commit fixes that by defining `round_nearest_inline` with an [@ocaml.inline] annotation, and then using that to define both `round_nearest` and `int63_round_nearest_portable_alloc_exn`. Signed-off-by: Jesse Tov <jtov@janestreet.com>
Signed-off-by: Jesse Tov <jtov@janestreet.com>
Signed-off-by: Jesse Tov <jtov@janestreet.com>
Signed-off-by: Jesse Tov <jtov@janestreet.com>
Signed-off-by: Jesse Tov <jtov@janestreet.com>
staronj
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.