expose getenv in Sys module #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Roché <louis@louisroche.net>
|
@Khady, thanks for your contribution! I'd like to make a few changes to make this PR follow Base's conventions. Could you please enable Allow edits from maintainers on this PR? |
|
|
Signed-off-by: Aaron L. Zeng <azeng@janestreet.com>
|
Oh. I figured out I was pushing to the wrong ref. My bad! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module Sys0 contains getenv and is included in Sys. But the function is not exposed. Given that reading from the environment is a pretty common operation, I'm proposing the add getenv in sys.mli.