Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display DSO if symbol is unknown #209

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

Xyene
Copy link
Member

@Xyene Xyene commented May 18, 2022

Closes #173.

Signed-off-by: Tudor Brindus tbrindus@janestreet.com

@Xyene Xyene requested a review from cgaebel May 18, 2022 00:35
Copy link
Contributor

@cgaebel cgaebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test with real dsos in it? Feel free to just regenerate one of the hello-world tests.

Also maybe worth trying a dso with spaces or close parens in the path, at least to demonstrate the edges of where things break down.

@shoffmeister
Copy link
Contributor

FWIW, I cherry-picked the one real applicable commit on top of the current master (git fetch git@github.com:Xyene/magic-trace.git track-dso && git cherry-pick 2578e7157256f399dd7cb07a6aaf7ae23e2668fd) and get

image

from doing an attach (as root) on a /usr/libexec/Xorg process (which is a Linux X11 server process).

From what I can tell, the module path / name resolution is correct (also the implicit vdso).

I'd be happy to see this in an official build.

Closes janestreet#173.

Signed-off-by: Tudor Brindus <tbrindus@janestreet.com>
Copy link
Contributor

@cgaebel cgaebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 8fe0614 into janestreet:master Jun 6, 2022
@Xyene Xyene deleted the track-dso branch June 6, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print DSO if symbol is unknown
3 participants