Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional format options for os/clock #1432

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

wishdev
Copy link
Contributor

@wishdev wishdev commented Mar 23, 2024

Allows for more flexibility in the returned value from os/clock

@sogaiu
Copy link
Contributor

sogaiu commented Mar 24, 2024

Some minor things about the proposed docstring:

For this bit of text in the docstring:

{seconds, nanoseconds}

May be it's better to not use curly braces as that's what's used for the literal syntax of structs.

Perhaps square brackets would work better?

Also, slight typo here?

  • :int: Return the number of seconds as am integer

May be "an" is what was intended (not "am"), though may be there is some humor value...

@wishdev
Copy link
Contributor Author

wishdev commented Mar 24, 2024

Fixed, thanks for the review!

@sogaiu
Copy link
Contributor

sogaiu commented Mar 24, 2024

Nice to have the tests :)

I tried the branch here manually successfully and the tests passed too.

@wishdev wishdev force-pushed the os/clock branch 2 times, most recently from 1577df6 to 623da13 Compare April 13, 2024 21:45
@bakpakin bakpakin merged commit f2e86d2 into janet-lang:master Apr 15, 2024
8 checks passed
@wishdev wishdev deleted the os/clock branch April 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants