Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chance to set the HTTP status in httpf #156

Closed
pepe opened this issue Oct 15, 2023 · 2 comments
Closed

Add chance to set the HTTP status in httpf #156

pepe opened this issue Oct 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pepe
Copy link
Member

pepe commented Oct 15, 2023

I already tried httpf on several projects and like the design choices. Yet, I am missing a chance to set the HTTP status code in the handler. Would you accept the PR with a mechanism similar to how response headers are set in the current version with a dynamic?

@bakpakin bakpakin added the enhancement New feature or request label Oct 20, 2023
@bakpakin
Copy link
Member

Yes, that would be reasonable if it becomes much easier to use. However, I think the request method is available in the parsed header (from spork/http.janet).

@pepe
Copy link
Member Author

pepe commented Oct 22, 2023

Thanks. I am unsure what you mean by the method's availability, but I will prepare PR for the HTTP status code ASAP.

psagers added a commit to psagers/spork that referenced this issue Apr 19, 2024
psagers added a commit to psagers/spork that referenced this issue Apr 19, 2024
psagers added a commit to psagers/spork that referenced this issue Apr 19, 2024
bakpakin added a commit that referenced this issue Apr 21, 2024
Fix #156: Look for (dyn :response-code) in spork/httpf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants