Add test suite to fmt, misc, msg and rpc. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fmt and misc, as low hanging fruits. Requesting a direction approval.
|
As a start, this looks good to me. Obviously, it’s a bit less obvious how to test networking utilities but first things first. |
|
Exactly my way of thinking. I will proceed with it. Sent with GitHawk |
Only reliable way to test it I found is to use threads. Also I had to add os/sleep so server has chance to start.
|
An only right way I have found is to use thread for the "server". I had to add some os/sleep to wait on server thread to start. How to test netrepl I do not know :-). |
pepe
changed the title
|
Closes #5 |
|
Thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only implemented tests for fmt and misc, as low hanging fruits. Requesting a direction approval :-)
As debated in #5