Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cohere remote API extension #2785

Merged
merged 11 commits into from
Apr 24, 2024
Merged

feat: cohere remote API extension #2785

merged 11 commits into from
Apr 24, 2024

Conversation

Inchoker
Copy link
Contributor

@Inchoker Inchoker commented Apr 22, 2024 •
edited
Loading

Describe Your Changes

  • Add transformMessage to core
  • Add transformResponse to core
  • Add Cohere support

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed
    image

@Inchoker Inchoker changed the title WIP: Feat/cohere Feat/cohere Apr 23, 2024
@Inchoker Inchoker requested review from namchuai and louis-jan and removed request for namchuai April 23, 2024 22:48
@Inchoker Inchoker marked this pull request as ready for review April 23, 2024 22:48
@louis-jan louis-jan changed the title Feat/cohere feat: cohere remote API extension Apr 24, 2024
@louis-jan
Copy link
Contributor

@Inchoker - It seems like you interrupted the screenshot upload. Should wait until it's fully uploaded before submitting.

Inchoker and others added 4 commits April 24, 2024 14:24
@Inchoker @louis-jan
Update extensions/inference-cohere-extension/src/index.ts
12c8a7f 
Co-authored-by: Louis <louis@jan.ai>
pass requestBody as object
6f85f09
transformPayload as a property
0df9395
This is not correct. CHATBOT is an equivalent role to assistant.
aec5274 
system message should be used with the preamble parameter and should not be included in the chat_history
louis-jan
louis-jan approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Inchoker Inchoker merged commit 96abd53 into dev Apr 24, 2024
7 checks passed
@Inchoker Inchoker deleted the feat/cohere branch April 24, 2024 11:16
@github-actions github-actions bot added this to the v0.4.13 milestone Apr 24, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 26, 2024

#2684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@Inchoker Inchoker

Labels
None yet
Projects
None yet
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.
3 participants
@Inchoker @louis-jan @Van-QA